Skip to content

Conversation

@pcsosinski
Copy link

#53688
Why: Beta blocker, Fix flutter version reporting
PRs

#54108
Fix web diagnostics
PRs

@fluttergithubbot
Copy link
Contributor

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.17-candidate.3. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master. The circumstances where this is valid are very rare.

/cc @dnfield

@fluttergithubbot fluttergithubbot changed the base branch from flutter-1.17-candidate.3 to master April 6, 2020 19:44
@fluttergithubbot fluttergithubbot added framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 6, 2020
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@pcsosinski pcsosinski changed the base branch from master to flutter-1.17-candidate.3 April 6, 2020 19:44
@pcsosinski pcsosinski added the CQ+1 label Apr 6, 2020
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cherry picks of my PRs LGTM

@ferhatb
Copy link
Contributor

ferhatb commented Apr 6, 2020

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 6, 2020
@pcsosinski pcsosinski merged commit d3ed9ec into flutter:flutter-1.17-candidate.3 Apr 6, 2020
@pcsosinski pcsosinski deleted the flutter-1.17-candidate.3 branch April 20, 2020 23:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants