Skip to content

update to engine hash that includes Dart 2.7.2 #53591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pcsosinski merged 1 commit into from
Mar 30, 2020
Merged

update to engine hash that includes Dart 2.7.2 #53591

pcsosinski merged 1 commit into from
Mar 30, 2020

Conversation

@pcsosinski
Copy link

@pcsosinski pcsosinski commented Mar 30, 2020

v1.12.13 hotfix #9 cherrypick of engine hash af51afceb8886cc11e25047523c4e0c7e1f5d408

only engine change of substance is a roll to Dart 2.7.2

see https://docs.google.com/document/d/1qTFdBeMaIa6wvvdyrSRtYDpgotxuz9gpBshgqrQsh1w/edit?ts=5e747afc# for details

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 30, 2020

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to v1.12.13-hotfixes. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master. The circumstances where this is valid are very rare.

/cc @dnfield

@fluttergithubbot fluttergithubbot changed the base branch from v1.12.13-hotfixes to master March 30, 2020 17:58
@fluttergithubbot fluttergithubbot added engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 30, 2020
@pcsosinski pcsosinski changed the base branch from master to v1.12.13-hotfixes March 30, 2020 17:58
christopherfujino
christopherfujino approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcsosinski pcsosinski merged commit f139b11 into flutter:v1.12.13-hotfixes Mar 30, 2020
@pcsosinski pcsosinski deleted the v1.12.13-hotfixes branch April 6, 2020 19:27
@iyuhang iyuhang mentioned this pull request May 14, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pcsosinski @fluttergithubbot @christopherfujino @tvolkert @googlebot