Skip to content

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Aug 11, 2016

Fixes #5023 better than #5222 did.

The key difference is that since the controller's state is now used in the build function, we have to setState() in the _stop() function and in the status handler.

Also added more tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out code?

@abarth
Copy link
Contributor

abarth commented Aug 11, 2016

LGTM

@Hixie Hixie merged commit 9c15407 into flutter:master Aug 11, 2016
@Hixie Hixie deleted the tap-scroll branch August 11, 2016 20:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stopping flings should not count as a touch

2 participants