Reland #53153 to attach to existing modules and apps for Android #53289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
reviewed
Mar 25, 2020
|
|
||
| await eventOrExit(listening.future); | ||
| await eventOrExit(ready.future); | ||
| await eventOrExit(ready.future).timeout(const Duration(seconds: 15), onTimeout: () { |
Member
There was a problem hiding this comment.
Why did this take more than 5 seconds in the devicelab so consistently? That seems like a long time...
How long does it take on your machine?
Member
Author
There was a problem hiding this comment.
Partly discussed offline. I thought it was just logcat pipe from the device but that's only taking 500ms.
Takes me ~8s to do a whole attach process. There's definitely some hot spots in the process. Filed #53313 to dig for low hanging fruits.
jmagman
approved these changes
Mar 25, 2020
Member
jmagman
left a comment
There was a problem hiding this comment.
LGTM, the only change is the timeout bump.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52975
The test failure was from the timeout which was overly aggressive. The attached signal came after we timed out and started to uninstall the app.