Remove invalid assert for TextHeightBehavior #50603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
justinmc
approved these changes
Feb 11, 2020
Contributor
justinmc
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick fix!
9 tasks
dnfield
reviewed
Feb 11, 2020
| ui.TextHeightBehavior get textHeightBehavior => _textHeightBehavior; | ||
| ui.TextHeightBehavior _textHeightBehavior; | ||
| set textHeightBehavior(ui.TextHeightBehavior value) { | ||
| assert(value != null); |
Contributor
There was a problem hiding this comment.
We should add a test for this so someone doesn't "helpfully" add it back...
Contributor
There was a problem hiding this comment.
(probably a very simple test with a link to the github issue for context)
Contributor
Author
|
Done! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#48346 (comment) caught an extra assert that slipped in. Remove this.
nullis a valid value for this and there should not be an assert here.