Skip to content

v1.12.13-hotfix.8#50591

Closed
christopherfujino wants to merge 3 commits into
stablefrom
v1.12.13-hotfixes
Closed

v1.12.13-hotfix.8#50591
christopherfujino wants to merge 3 commits into
stablefrom
v1.12.13-hotfixes

Conversation

@christopherfujino

@christopherfujino christopherfujino commented Feb 11, 2020

Copy link
Copy Markdown
Contributor

This cherry picks:
#50489 - upgrade Gradle in infra to make CI pass
flutter-team-archive/engine#16344 - rebuild engine artifacts and codesign
#50074 - add an integration test to verify binaries are codesigned when merging to non-master branches
#50315 - increase minimum supported Xcode version to 11.0 (pre v11.0 support broke in a previous hotfix)
#45743 - fixed android log reader regression
#49327 - fixed flutter run failing for pre-version 4.4

@fluttergithubbot fluttergithubbot changed the base branch from stable to master February 11, 2020 20:39
@fluttergithubbot

Copy link
Copy Markdown
Contributor

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to stable. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master. The circumstances where this is valid are very rare.

/cc @dnfield

@fluttergithubbot fluttergithubbot added engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Feb 11, 2020
@christopherfujino christopherfujino changed the base branch from master to stable February 11, 2020 20:39
@christopherfujino christopherfujino marked this pull request as ready for review February 11, 2020 20:48
@christopherfujino

Copy link
Copy Markdown
Contributor Author

@tvolkert I know the release process says to just push straight to stable, but I opened a PR so that I could squash and merge the three commits onto stable (also I didn't follow the existing commit message scheme on the hotfix branch).

@christopherfujino

Copy link
Copy Markdown
Contributor Author

Chatted offline, closing this and will push the tag directly to stable.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants