Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 7, 2020

Description

  • globals.cache is nil when the build command is created, it's populated later. Instead, lazily set the cache property to globals.cache if it's not injected by a test.
  • Previously the --cocoapods flag was forbidden on the master branch to force a valid semantic version on the podspec. Add a --force flag for integration testing on the master channel.

Related Issues

Fixes #50364.

Tests

Added unit test for the --force flag and an integration test for the --cocoapods flag.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: existing-apps Integration with existing apps via the add-to-app flow labels Feb 7, 2020
@jmagman jmagman self-assigned this Feb 7, 2020
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 7, 2020
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmagman jmagman merged commit 082ae83 into flutter:master Feb 7, 2020
@jmagman jmagman deleted the inject-cache branch February 7, 2020 23:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: existing-apps Integration with existing apps via the add-to-app flow c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flutter build ios-framework --cocoapods crashes: "NoSuchMethodError: The method 'getLicenseFile' was called on null.

4 participants