Reland "install goldctl in docker build" #50124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev/ci/docker_linux/Dockerfile
Outdated
| RUN bundle install --system | ||
|
|
||
| # Install goldctl, for Golden testing | ||
| # Last updated 1/8/19 (update to rebuild Dockerfile with latest goldctl) |
Contributor
There was a problem hiding this comment.
While you're at it, can you update this date, so we can cache bust and get the newest goldctl?
christopherfujino
approved these changes
Feb 4, 2020
Contributor
christopherfujino
left a comment
There was a problem hiding this comment.
thanks dan, lgtm
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
|
Hmm, the docker build is failing with: Not sure why, I can do this locally... |
Contributor
|
@dnfield if you change line 97 in the dockerfile to include |
dnfield
commented
Feb 4, 2020
| RUN mkdir -p "${GRADLE_ROOT}" | ||
| ENV GRADLE_ARCHIVE="${GRADLE_ROOT}/gradle.zip" | ||
| ENV GRADLE_URL="http://services.gradle.org/distributions/gradle-4.4-bin.zip" | ||
| ENV GRADLE_URL="https://services.gradle.org/distributions/gradle-4.4-bin.zip" |
Contributor
Author
|
This is very consistently failing on the goldctl flake. I'll wait for @Piinks' other PR to land and merge it into this one. |
Contributor
|
Patch is in. This can be updated and should no longer experience the flake. 😄 |
…rt-46640-refactor-dockerfile
Contributor
Author
|
I'm going to land this on red since it is a CI only change that should only help the health of the tree. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #50088
The flakes this was meant to fix are still occurring after this change.