Skip to content

WIP Turn back on macOS shard Cirrus caching #49585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jmagman wants to merge 13 commits into from
Closed

WIP Turn back on macOS shard Cirrus caching #49585

jmagman wants to merge 13 commits into from

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jan 28, 2020

Description

At one point it was faster to directly re-download assets needed for macOS shards than to use the cache. Try turning the caches back on now that the Cirrus Macs have been upgraded to Catalina.

Related Issues

Reverts part of #37880.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Jan 28, 2020
@jmagman jmagman requested a review from dnfield January 28, 2020 00:41
@jmagman jmagman self-assigned this Jan 28, 2020
@dnfield
Copy link
Contributor

dnfield commented Jan 28, 2020

Did you check if it's faster now?

@jmagman
Copy link
Member Author

jmagman commented Jan 28, 2020

This PR is the test, https://cirrus-ci.com/task/4992266552999936 missed the cache (obviously), going to see how the other tasks that run after it do.

@jmagman jmagman changed the title Turn back on macOS shard Cirrus caching WIP Turn back on macOS shard Cirrus caching Jan 28, 2020
@jmagman
Copy link
Member Author

jmagman commented Jan 28, 2020

The slight speed up in setup doesn't look like it's adding up to the time it takes to download and re-upload the cache, which I would think happens often enough with constant engine rolls. Closing.

@jmagman jmagman closed this Jan 28, 2020
@jmagman jmagman deleted the cache-cirrus branch January 28, 2020 19:10
@jmagman jmagman restored the cache-cirrus branch February 10, 2020 20:33
@jmagman jmagman mentioned this pull request Feb 10, 2020
Merged
10 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dnfield dnfield Awaiting requested review from dnfield

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @dnfield @googlebot