Skip to content

Remove simulator arch in Profile and Release, App.xcframework #48002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Jan 2, 2020
Merged

Remove simulator arch in Profile and Release, App.xcframework #48002

fluttergithubbot merged 1 commit into from
Jan 2, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Dec 31, 2019

Description

  • Create App.xcframework
  • Strip x86_64 from all frameworks in Profile and Release. This allows the frameworks to be codesigned during archive.

Related Issues

Fixes #44492
Fixes #47930

Tests

Added cases to build_ios_framework_module_test.dart

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added tool Affects the "flutter" command-line tool. See also t: labels. a: existing-apps Integration with existing apps via the add-to-app flow labels Dec 31, 2019
@jmagman jmagman requested a review from xster December 31, 2019 03:34
@jmagman jmagman self-assigned this Dec 31, 2019
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Dec 31, 2019
@xster
Copy link
Member

xster commented Dec 31, 2019

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jan 2, 2020

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@fluttergithubbot fluttergithubbot merged commit dc99d61 into flutter:master Jan 2, 2020
@jmagman jmagman deleted the thin-fw branch January 2, 2020 21:13
@jmagman jmagman added the platform-ios iOS applications specifically label Aug 21, 2020
@jmagman jmagman mentioned this pull request Sep 24, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xster xster xster approved these changes

Assignees

@jmagman jmagman

Labels

a: existing-apps Integration with existing apps via the add-to-app flow c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

4 participants

@jmagman @xster @fluttergithubbot @googlebot