Skip to content

Fix semantics and transition-perf tests to parse new event format. #47899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flar merged 1 commit into from
Dec 28, 2019
Merged

Fix semantics and transition-perf tests to parse new event format. #47899

flar merged 1 commit into from
Dec 28, 2019

Conversation

@flar
Copy link
Contributor

@flar flar commented Dec 28, 2019

This should fix the remaining tests.

@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. labels Dec 28, 2019
franciscojma86
franciscojma86 approved these changes Dec 28, 2019
View reviewed changes
Copy link
Contributor

@franciscojma86 franciscojma86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@flar flar merged commit cf00b96 into flutter:master Dec 28, 2019
@flar flar mentioned this pull request Dec 28, 2019
Merged
@flar flar deleted the fix-semantics-transition-test-event-parsing branch September 4, 2020 19:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a14n a14n Awaiting requested review from a14n

@goderbauer goderbauer Awaiting requested review from goderbauer

1 more reviewer

@franciscojma86 franciscojma86 franciscojma86 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. d: examples Sample code and demos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@flar @franciscojma86 @googlebot @fluttergithubbot