Skip to content

Revert "Roll engine 12bf95fd49b7..140818a71532 (2 commits)" #46695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
clocksmith merged 1 commit into from
Dec 10, 2019
Merged

Revert "Roll engine 12bf95fd49b7..140818a71532 (2 commits)" #46695

clocksmith merged 1 commit into from
Dec 10, 2019

Conversation

@clocksmith
Copy link
Contributor

@clocksmith clocksmith commented Dec 10, 2019

Reverts #46667

@fluttergithubbot fluttergithubbot added the engine flutter/engine related. See also e: labels. label Dec 10, 2019
iskakaushik
iskakaushik approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clocksmith clocksmith merged commit 5469804 into master Dec 10, 2019
@clocksmith
Copy link
Contributor Author

clocksmith commented Dec 10, 2019

This left 1 android and 2 mac tests failing

@tvolkert tvolkert deleted the revert-46667-roll_branch branch December 11, 2019 05:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@engine-flutter-autoroll engine-flutter-autoroll Awaiting requested review from engine-flutter-autoroll

1 more reviewer

@iskakaushik iskakaushik iskakaushik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@clocksmith @iskakaushik @googlebot @fluttergithubbot