[flutter_tools] Fix for Unsupported Android Plugin version. by slightfoot · Pull Request #46260 · flutter/flutter

slightfoot · 2019-12-06T22:59:01Z

Build getting a weird error since upgrade:
Unsuported Android Plugin version: 3.5.2

Tracked it down to this line:

flutter/packages/flutter_tools/lib/src/android/gradle_utils.dart

Line 203 in 4f54e46

throwToolExit('Unsuported Android Plugin version: $androidPluginVersion.');

According to the comments above the function the details for this compatibility was from https://developer.android.com/studio/releases/gradle-plugin#updating-gradle which clearly states 3.5.0+ requires gradle version 5.6.4. This is not what is in the dart code for the flutter tool and so the latest android plugin/studio builds 3.5.1 to 3.5.3 are not compatible with the latest hotfix branch of the tool.

fluttergithubbot · 2019-12-06T22:59:04Z

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to dev. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master. The circumstances where this is valid are very rare.

/cc @dnfield

fluttergithubbot · 2019-12-06T22:59:05Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

blasten · 2019-12-06T23:33:08Z

This probably needs a unit test

timsneath · 2019-12-07T00:21:08Z

Marking for consideration as release blocker. cc @tvolkert

blasten · 2019-12-07T00:38:28Z

I don't think it's a release blocker since we don't expect folks to upgrade Gradle/Android Gradle plugin on their own. We also need to make sure that those components are compatible with the Flutter Gradle plugin. This AGP version might work, but generally speaking we want to have test for each version that we support.

blasten · 2019-12-07T01:53:44Z

To summarize, Android Studio 3.5.3 started showing a banner that recommends to update the Android Gradle plugin to a version that the tool doesn't handle.

I'm not sure about the full impact of this issue though.

blasten · 2019-12-07T01:57:16Z

packages/flutter_tools/lib/src/android/gradle_utils.dart

    return '5.6.2';
  }
-  throwToolExit('Unsuported Android Plugin version: $androidPluginVersion.');
+  if (Version.parse(androidPluginVersion) > Version.parse('3.5.0')) {


maybe just return '5.6.4' and remove this check and throwToolExit. Finally, update the unit test.

tvolkert · 2019-12-07T07:26:08Z

This definitely needs a test.

Also, are we sure this is a release blocker? How common do we expect this failure mode to be?

dnfield · 2019-12-07T14:23:37Z

I don't think this should be a release blocker. We need to do testing to make sure this all plays nicely. It's not on our default templates yet and using it may have other problems that need to be vetted out.

We should definitely fix this but it should really go through a longer cycle on dev/beta before being brought into the release.

timsneath · 2019-12-07T19:31:49Z

I'll trust you all for making the right call on release blocker or not. A better tag at this point might be "hotfix candidate", perhaps?

…

On Sat, Dec 7, 2019 at 6:23 AM Dan Field ***@***.***> wrote: I don't think this should be a release blocker. We need to do testing to make sure this all plays nicely. It's not on our default templates yet and using it may have other problems that need to be vetted out. We should definitely fix this but it should really go through a longer cycle on dev/beta before being brought into the release. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#46260?email_source=notifications&email_token=AARWL67GDCB2VHOMZGRPLALQXOWWXA5CNFSM4JXDBNGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGH4CA#issuecomment-562855432>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARWL63FQVMV2NK22GCXCNLQXOWWXANCNFSM4JXDBNGA> .

tvolkert · 2019-12-09T18:34:01Z

Removing release blocker label. As @dnfield and @blasten say, we really should do more comprehensive testing of this through the normal channels and give it time to bake.

zanderso · 2020-01-09T18:09:03Z

@blasten is this PR still relevant?

blasten · 2020-01-09T18:59:25Z

I think so. @slightfoot are you still interested in working on this PR?

slightfoot · 2020-01-10T02:38:05Z

I think so. @slightfoot are you still interested in working on this PR?

Sure.

sidhijakpat · 2020-01-11T17:40:34Z

In my case this is happening when I run flutter build apk with
setProperty("archivesBaseName", "AppName-" + versionName + "_" + versionCode) enabled,

when I disable those line, flutter build apk was running just fine.

I try to build the release apk using android studio, by opening android folder on project, and it turn out to be fine with those line enabled.

maybe it can help you tracing the error.

additional note:

➜  ~ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, v1.12.13+hotfix.5, on Mac OS X 10.15.2 19C57,
    locale en)

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor
      --android-licenses
[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
[✓] Android Studio (version 3.5)
[✓] Connected device (1 available)

classpath 'com.android.tools.build:gradle:3.5.3'

Another note:
running
flutter clean
flutter pub cache repair

didn't fix the issue

sidhijakpat · 2020-01-22T06:25:36Z

turn out the problem is occur too when try to run on android,
not only flutter build apk,

In my case this is happening when I run flutter build apk with
setProperty("archivesBaseName", "AppName-" + versionName + "_" + versionCode) enabled,

when I disable those line, flutter build apk was running just fine.

I try to build the release apk using android studio, by opening android folder on project, and it turn out to be fine with those line enabled.

maybe it can help you tracing the error.

additional note:
➜  ~ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, v1.12.13+hotfix.5, on Mac OS X 10.15.2 19C57,
    locale en)

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor
      --android-licenses
[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
[✓] Android Studio (version 3.5)
[✓] Connected device (1 available)
classpath 'com.android.tools.build:gradle:3.5.3'

Another note:
running
flutter clean
flutter pub cache repair

didn't fix the issue

blasten · 2020-01-24T19:13:55Z

I filed #49438. This will likely involve updating the Gradle version in the template as well.

abhimangalms · 2020-01-27T13:20:43Z

I'm also facing the same issue.
current Gradle version is 5.4.1. But still nothing happens.

[flutter_tools] Fix for Unsupported Android Plugin version.

f96d749

fluttergithubbot changed the base branch from dev to master December 6, 2019 22:59

googlebot added the cla: yes label Dec 6, 2019

fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 6, 2019

dnfield requested a review from blasten December 6, 2019 23:10

timsneath added the RELEASE BLOCKER label Dec 7, 2019

blasten suggested changes Dec 7, 2019

View reviewed changes

tvolkert removed the RELEASE BLOCKER label Dec 9, 2019

zanderso assigned blasten Dec 12, 2019

zanderso added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Dec 19, 2019

arnemolland mentioned this pull request Dec 25, 2019

gradle 3.5.3 #47072

Closed

blasten mentioned this pull request Jan 24, 2020

Upgrade the Gradle version in the project template #49438

Closed

blasten closed this Jan 24, 2020

GRBurst mentioned this pull request Feb 28, 2020

flutter: init 1.12.13+hotfix.8 NixOS/nixpkgs#76420

Merged

10 tasks

github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021

Conversation

slightfoot commented Dec 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fluttergithubbot commented Dec 6, 2019

Uh oh!

fluttergithubbot commented Dec 6, 2019

Uh oh!

blasten commented Dec 6, 2019

Uh oh!

timsneath commented Dec 7, 2019

Uh oh!

blasten commented Dec 7, 2019

Uh oh!

blasten commented Dec 7, 2019

Uh oh!

blasten Dec 7, 2019

Choose a reason for hiding this comment

Uh oh!

tvolkert commented Dec 7, 2019

Uh oh!

dnfield commented Dec 7, 2019

Uh oh!

timsneath commented Dec 7, 2019 via email

Uh oh!

tvolkert commented Dec 9, 2019

Uh oh!

zanderso commented Jan 9, 2020

Uh oh!

blasten commented Jan 9, 2020

Uh oh!

slightfoot commented Jan 10, 2020

Uh oh!

sidhijakpat commented Jan 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sidhijakpat commented Jan 22, 2020

Uh oh!

blasten commented Jan 24, 2020

Uh oh!

abhimangalms commented Jan 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

slightfoot commented Dec 6, 2019 •

edited

Loading

sidhijakpat commented Jan 11, 2020 •

edited

Loading