Reland: Attach looks at future observatory URIs #45307
Conversation
Co-Authored-By: Jonah Williams <jonahwilliams@google.com>
|
LGTM |
|
This seems to have broken all our microbenchmarks? |
|
Emmanuel's out this week. Running @godofredoc may have ideas? |
|
Old runs of the microbenchmarks have 9 different metrics: New version has 9 copies of "stock_layout_iteration": |
|
I'm going to try reverting this to see if it fixes the problem. |
|
Can't revert cleanly. |
| _timeOrigin = null; | ||
| } | ||
| // Start the adb logcat process and filter logs by the "flutter" tag. | ||
| final List<String> args = <String>['shell', '-x', 'logcat', '-v', 'time', '-s', 'flutter']; |
There was a problem hiding this comment.
we shouldn't exclude non-flutter tags, otherwise we'll miss things like crash reports.
| } | ||
| } | ||
| if (line.length == timeMatch.end) { | ||
| if (timeMatch == null || line.length == timeMatch.end) { |
There was a problem hiding this comment.
why are we removing the origin checking? this will make things like flutter logs display old logs.
There was a problem hiding this comment.
this may be the cause of the regression, in fact...
|
Filed as #45732. |
Relands: #44637