add clipBehaviour to Container #43564

sahandevs · 2019-10-26T07:08:21Z

Description

added clipBehaviour to Container

if (clipBehaviour != null &&
        clipBehaviour != Clip.none &&
        decoration is BoxDecoration) {
      final BoxDecoration _decoration = decoration;
      current = ClipRRect(
        borderRadius: _decoration.borderRadius,
        clipBehavior: clipBehaviour,
        child: current,
      );
    }

i did cast the decoration to BoxDecoration because i need access to the borderRadius for the ClipRRect

Related Issues

resolves #14421

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I updated/added relevant documentation (doc comments with ///).
All existing and new tests are passing.
The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
No, this is not a breaking change.

fluttergithubbot · 2019-10-26T07:08:23Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Piinks

Hi @sahandevs,
Welcome! and thank you for the contribution! 🎉
This change will need a test to ensure the behavior you are adding matches expectations.

Piinks · 2019-10-29T22:12:09Z

packages/flutter/lib/src/widgets/container.dart


  /// The transformation matrix to apply before painting the container.
  final Matrix4 transform;
+  /// clipBehaviour for [BoxDecoration.borderRadius]


Nit: blank line above this, and a full sentence description

Suggested change

/// clipBehaviour for [BoxDecoration.borderRadius]

/// clipBehaviour for [BoxDecoration.borderRadius]

sahandevs · 2019-10-30T19:58:57Z

Hi @Piinks, Thanks!

I added some tests and fixed the doc.

goderbauer · 2019-10-31T00:03:32Z

packages/flutter/lib/src/widgets/container.dart

  final Matrix4 transform;

+  /// The clip behaviour when [BoxDecoration.borderRadius] is available.
+  /// 


nit: there's a trailing whitespace here that should be removed.

goderbauer · 2019-10-31T00:05:39Z

packages/flutter/lib/src/widgets/container.dart


+    if (clipBehaviour != null &&
+        clipBehaviour != Clip.none &&
+        decoration is BoxDecoration) {


It's strange that the clipping will only work for BoxDecorations. What about a ShapeDecoration? Or any other decoration?

we need to access the borderRadius inside the decoration

We can just check for BoxDecoration ( Wich will support must use cases )

Or We can create interface like ShapeWithBorder and add it to the all decorations

Or we can just add another property in the Container as 'borderRadius' and use that

Wich one do you think is the best? @goderbauer

We should ensure that this works for all decorations. We probably need to add something to the Decoration base class to get a clipPath (similar to ShapeBorder.getOutterPath) and then use that here.

Piinks · 2019-11-11T17:48:20Z

Hi @sahandevs, are you planning on returning to this? It looks like the analyzer has detected whitespace in your changes.

sahandevs · 2019-11-12T04:12:23Z

@Piinks I'm waiting for @goderbauer response

sahandevs · 2019-11-14T07:23:55Z

@goderbauer I've added getBorderRadius to Decoration class and implemented it in BoxDecoration and ShapeDecoration if this approach is OK I will add docs and some tests for it

goderbauer · 2019-11-14T18:09:56Z

packages/flutter/lib/src/painting/shape_decoration.dart

    this.image,
    this.gradient,
    this.shadows,
+    this.borderRadius,


Adding a borderRadius here doesn't make much sense - especially since the class just seems to ignore it.

Instead, a shapeDecoration should be clipped to its shape.

goderbauer · 2019-11-14T18:10:39Z

packages/flutter/lib/src/painting/decoration.dart

  /// if it is a [BoxDecoration] with definitely no [DecorationImage]).
  BoxPainter createBoxPainter([ VoidCallback onChanged ]);
+
+  BorderRadius getBorderRadius() => null;


Not all decorations have a border radius. This will probably have to return a more generic clip Path.

goderbauer · 2019-11-14T18:11:48Z

Also: to fix the tests you'll have to merge the latest master into your PR.

#44027)" This reverts commit 2bbb85d.

This reverts commit 3bca73b.

This reverts commit 464a567.

…4761)" This reverts commit 52a9f98.

This reverts commit 451a0fe.

This reverts commit f9ade49.

#44633)" This reverts commit e5b66a9.

This reverts commit ed05f01.

This reverts commit 9981db9.

This reverts commit 2f8bed2.

This reverts commit 1b84d8a.

…44625)" This reverts commit 7edc16f.

This reverts commit 4835e63.

This reverts commit 8749ddf.

This reverts commit a7eaf4d.

This reverts commit f208671.

This reverts commit e3b3c1e.

This reverts commit f21562f.

This reverts commit 6cd5a6c.

This reverts commit 8708598.

This reverts commit 5a146d2.

…tches, checkboxes, and radio buttons. (#43384)" (#43647)" This reverts commit e6d9009.

This reverts commit bb0bfe1.

…nt (#42479)" This reverts commit f66a0f6.

This reverts commit 08e434c.

…heckboxes, and radio buttons. (#43384)" This reverts commit cc6f7e8.

This reverts commit fa1cfcf.

This reverts commit 25d6bd1.

This reverts commit ecf3e61.

This reverts commit b3e7ce1.

This reverts commit ec12f4c.

This reverts commit 6ed30cf.

…42476)" This reverts commit e2b7aba.

… commits) (#43563)" This reverts commit 3934dc6.

#43611)" This reverts commit 15d8416.

…d a getBinaryMessenger() method. (#43202) (flutter/engine#13349) (#43562)" This reverts commit 215284f.

This reverts commit 5156a80.

Revert "Merge master"

googlebot · 2019-11-15T06:15:36Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

sahandevs · 2019-11-15T06:23:01Z

I Created a new pull request because of the mess #44971

fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 26, 2019

googlebot added the cla: yes label Oct 26, 2019

Piinks reviewed Oct 29, 2019

View reviewed changes

goderbauer reviewed Oct 31, 2019

View reviewed changes

Piinks added the c: new feature Nothing broken; request for a new capability label Nov 4, 2019

goderbauer reviewed Nov 14, 2019

View reviewed changes

sahandevs requested a review from jmagman as a code owner November 15, 2019 06:13

sahandevs added 17 commits November 15, 2019 09:44

Revert "Allow specifying device-vmservice-port and host-vmservice-port (

5e7bfcf

#44027)" This reverts commit 2bbb85d.

Revert "Make disposing a ScrollPosition with pixels=null legal (#44617)"

ef3ea2c

This reverts commit 3bca73b.

Revert "Canonicalize locale string in gen_l10n.dart (#44758)"

3ae67b5

This reverts commit 464a567.

Revert "Sort locales and method/properties/getters alphabetically (#4…

012fd94

…4761)" This reverts commit 52a9f98.

Revert "Forward ProcessException to error handlers (#44783)"

64ce896

This reverts commit 451a0fe.

Revert "ModalBarrier and Drawer barrier prevents mouse events (#44296)"

91fbc16

This reverts commit f9ade49.

Revert "Turn on bitcode for integration tests and add-to-app templates (

92a1a86

#44633)" This reverts commit e5b66a9.

Revert "refactorings to testbed.run and testbed.test (#44488)"

ba22db8

This reverts commit ed05f01.

Revert "disable chrome devicelab test (#44746)"

f6249d6

This reverts commit 9981db9.

Revert "Ensure web-server does not force usage of dwds (#44744)"

adeda3f

This reverts commit 2f8bed2.

Revert "Always link desktop platforms (#44753)"

6e473f1

This reverts commit 1b84d8a.

Revert "Release startup lock during long-lived build ios framework (#…

f95ea74

…44625)" This reverts commit 7edc16f.

Revert "Update meta to 1.1.8 (#44584)"

aeb46eb

This reverts commit 4835e63.

Revert "Sort Localization generation output (#44743)"

6de5251

This reverts commit 8749ddf.

Revert "Check in new diffs to material localizations (#44736)"

cf7c4e3

This reverts commit a7eaf4d.

Revert "Bump memory requirements for tool_tests-general-linux (#44620)"

0d854a9

This reverts commit f208671.

Revert "Show a warning when a module uses a v1 only plugin (#44499)"

988a492

This reverts commit e3b3c1e.

sahandevs added 21 commits November 15, 2019 09:44

Revert "Implement AlertDialog title/content overflow scroll (#43226)"

b68a58b

This reverts commit f21562f.

Revert "Improve DropdownButton assert message (#43511)"

be91fc4

This reverts commit 6cd5a6c.

Revert "Roll engine 869b74e..728e473 (2 commits) (#43652)"

2058eac

This reverts commit 8708598.

Revert "Enable tests that failed due to CupertinoDynamicColor (#43636)"

41a5936

This reverts commit 5a146d2.

Revert "Revert "Re-Land: Add focus nodes, hover, and shortcuts to swi…

d6760ab

…tches, checkboxes, and radio buttons. (#43384)" (#43647)" This reverts commit e6d9009.

Revert "Add more structure to errors (continuation of #34684) (#42640)"

99742d5

This reverts commit bb0bfe1.

Revert "Make DropdownButton's disabledHint and hint behavior consiste…

f8d818c

…nt (#42479)" This reverts commit f66a0f6.

Revert "No multiline password fields (#42470)"

873f48f

This reverts commit 08e434c.

Revert "Re-Land: Add focus nodes, hover, and shortcuts to switches, c…

2b17399

…heckboxes, and radio buttons. (#43384)" This reverts commit cc6f7e8.

Revert "catch failure to parse FLUTTER_STORAGE_BASE_URL (#43599)"

f050b37

This reverts commit fa1cfcf.

Revert "set trace to true for desktop builds (#43577)"

71e8d84

This reverts commit 25d6bd1.

Revert "Catch MissingPortFile exception (#43573)"

0641085

This reverts commit ecf3e61.

Revert "Ensure Chrome is closed on tab close (#43586)"

f3c6c08

This reverts commit b3e7ce1.

Revert "Roll engine 6c257df..869b74e (15 commits) (#43637)"

bfe9dc0

This reverts commit ec12f4c.

Revert "[flutter_tool] Use engine flutter_runner prebuilts (#43381)"

3bc19de

This reverts commit 6ed30cf.

Revert "Refactor BuildMode into class, add jit_release configuration (#…

1afe49d

…42476)" This reverts commit e2b7aba.

Revert "6c257df8e Roll src/third_party/dart 6354b0b97d..d166b0be1c (4…

ee47643

… commits) (#43563)" This reverts commit 3934dc6.

Revert "Revert "Migrate examples to the Android embedding v2 (#43221)" (

32ba634

#43611)" This reverts commit 15d8416.

Revert "3ebf00690 Deprecated DartExecutor as BinaryMessenger and adde…

29e0126

…d a getBinaryMessenger() method. (#43202) (flutter/engine#13349) (#43562)" This reverts commit 215284f.

Revert "Migrate examples to the Android embedding v2 (#43221)"

d0e0572

This reverts commit 5156a80.

Merge pull request #3 from sahandevs/revert-2-master

f5d759f

Revert "Merge master"

googlebot added cla: no and removed cla: yes labels Nov 15, 2019

sahandevs mentioned this pull request Nov 15, 2019

Add clip behaviour to Container #44971

Merged

9 tasks

sahandevs closed this Nov 15, 2019

github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021

	/// clipBehaviour for [BoxDecoration.borderRadius]

	/// clipBehaviour for [BoxDecoration.borderRadius]

add clipBehaviour to Container #43564

add clipBehaviour to Container #43564

Uh oh!

Conversation

sahandevs commented Oct 26, 2019

Description

Related Issues

Checklist

Breaking Change

Uh oh!

fluttergithubbot commented Oct 26, 2019

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sahandevs commented Oct 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Piinks commented Nov 11, 2019

Uh oh!

sahandevs commented Nov 12, 2019

Uh oh!

sahandevs commented Nov 14, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

goderbauer commented Nov 14, 2019

Uh oh!

googlebot commented Nov 15, 2019

Uh oh!

sahandevs commented Nov 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sahandevs commented Oct 30, 2019 •

edited

Loading