Skip to content

V1.9.1 hotfixes #41229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tvolkert merged 3 commits into from
Sep 25, 2019
Merged

V1.9.1 hotfixes #41229

tvolkert merged 3 commits into from
Sep 25, 2019

Conversation

@tvolkert
Copy link
Contributor

@tvolkert tvolkert commented Sep 24, 2019

Bump version of just package:multicast_dns (#41207)
Implement mdns for flutter run (#40447)

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Sep 24, 2019

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to v1.9.1-hotfixes. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master. The circumstances where this is valid are very rare.

/cc @dnfield

@fluttergithubbot fluttergithubbot changed the base branch from v1.9.1-hotfixes to master September 24, 2019 21:43
@fluttergithubbot fluttergithubbot added engine flutter/engine related. See also e: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 24, 2019
@tvolkert tvolkert changed the base branch from master to v1.9.1-hotfixes September 24, 2019 21:43
@christopherfujino
Copy link
Contributor

christopherfujino commented Sep 24, 2019

I'll test this locally....

christopherfujino
christopherfujino approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, runs for me locally both on iOS13 and iOS12

@codecov
Copy link

codecov bot commented Sep 24, 2019 •
edited
Loading

Codecov Report

Merging #41229 into v1.9.1-hotfixes will decrease coverage by 0.64%.
The diff coverage is 70.73%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           v1.9.1-hotfixes   #41229      +/-   ##
===================================================
- Coverage            56.11%   55.47%   -0.65%     
===================================================
  Files                  195      196       +1     
  Lines                18261    18277      +16     
===================================================
- Hits                 10248    10140     -108     
- Misses                8013     8137     +124
Flag Coverage Δ
#flutter_tool 55.47% <70.73%> (-0.65%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/context_runner.dart 67.3% <0%> (-1.32%) ⬇️
...ackages/flutter_tools/lib/src/commands/attach.dart 73.48% <62.5%> (-0.85%) ⬇️
packages/flutter_tools/lib/src/mdns_discovery.dart 69.84% <69.84%> (ø)
packages/flutter_tools/lib/src/ios/devices.dart 61.35% <90%> (+0.69%) ⬆️
packages/flutter_tools/lib/src/devfs.dart 14.77% <0%> (-53.7%) ⬇️
...ckages/flutter_tools/lib/src/commands/upgrade.dart 4.59% <0%> (-29.89%) ⬇️
packages/flutter_tools/lib/src/commands/logs.dart 6.25% <0%> (-12.5%) ⬇️
packages/flutter_tools/lib/src/features.dart 74.46% <0%> (-10.64%) ⬇️
packages/flutter_tools/lib/src/bundle.dart 71.21% <0%> (-4.55%) ⬇️
packages/flutter_tools/lib/src/base/os.dart 28.22% <0%> (-1.62%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ced75c...fc73b41. Read the comment docs.

@tvolkert
Copy link
Contributor Author

tvolkert commented Sep 25, 2019

@christopherfujino can you take a look at the test failures? They're more than the known failures on the tip of this branch.

@christopherfujino
Copy link
Contributor

christopherfujino commented Sep 25, 2019

@tvolkert tool_tests are failing because the version file (flutter/version) doesn't match the regex pattern--because this commit hasn't been tagged yet, the version file contains 1.9.1+hotfix.3-pre.3. I think the regex for this test needs to be changed, opened #41310.

zanderso
zanderso approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@christopherfujino
Copy link
Contributor

christopherfujino commented Sep 25, 2019

lgtm, looks like the tools tests have passed.

@tvolkert tvolkert merged commit a72edc2 into flutter:v1.9.1-hotfixes Sep 25, 2019
@tvolkert tvolkert deleted the v1.9.1-hotfixes branch September 25, 2019 22:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso zanderso approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tvolkert @fluttergithubbot @christopherfujino @zanderso @googlebot