Skip to content

Revert "Added a composable waitForCondition Driver/extension API (#37… #38815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adazh merged 1 commit into from
Aug 19, 2019
Merged

Revert "Added a composable waitForCondition Driver/extension API (#37… #38815

adazh merged 1 commit into from
Aug 19, 2019

Conversation

@adazh
Copy link
Contributor

@adazh adazh commented Aug 19, 2019

…736)"

This reverts commit 8edc3f7.

Description

The original commit broke devicelab tests. Reverting.

Related Issues

#37409

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Aug 19, 2019
@adazh adazh requested a review from tvolkert August 19, 2019 17:53
@codecov
Copy link

codecov bot commented Aug 19, 2019 •
edited
Loading

Codecov Report

Merging #38815 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #38815   +/-   ##
=======================================
  Coverage   56.24%   56.24%           
=======================================
  Files         195      195           
  Lines       18275    18275           
=======================================
  Hits        10278    10278           
  Misses       7997     7997
Flag Coverage Δ
#flutter_tool 56.24% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8edc3f7...0e8ead0. Read the comment docs.

jonahwilliams
jonahwilliams approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

you can land reverts without waiting for CI

@adazh adazh merged commit df2db4e into flutter:master Aug 19, 2019
@adazh adazh mentioned this pull request Aug 19, 2019
Merged
9 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tvolkert tvolkert Awaiting requested review from tvolkert

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adazh @jonahwilliams @googlebot @fluttergithubbot