Skip to content

Conversation

@excitedhaha
Copy link

Description

Fix the problem that no flutter assets merged to the apk.

Related Issues

38286

Tests

Tested in my project

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 14, 2019
@excitedhaha
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@dnfield dnfield requested a review from blasten August 15, 2019 07:02
@dnfield dnfield added the t: gradle "flutter build" and "flutter run" on Android label Aug 15, 2019
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blasten will probably have much better feedback here, but this breaks some existing tests and doesn't add any new ones to cover this case. We won't be able to merge this PR without addressing those issues.

@dnfield dnfield added a: assets Packaging, accessing, or using assets a: existing-apps Integration with existing apps via the add-to-app flow labels Aug 15, 2019
@blasten
Copy link

blasten commented Aug 29, 2019

For reference, this is being discussed on #38286

@kf6gpe kf6gpe added this to the December 2019 (Add-to-App) milestone Aug 29, 2019
@zanderso
Copy link
Member

zanderso commented Sep 5, 2019

As discussed here and on the issue, this PR needs work on tests. @excitedhaha are you interested in continuing with this PR?

@zanderso zanderso added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Sep 5, 2019
@excitedhaha
Copy link
Author

@zanderso ok, I will try to give the exact steps that reproduce the issue

@blasten blasten mentioned this pull request Sep 27, 2019
9 tasks
@blasten
Copy link

blasten commented Sep 27, 2019

This issue was fixed via #41333. If you still see this issue, feel free to comment on the PR or the issue.

@blasten blasten closed this Sep 27, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: assets Packaging, accessing, or using assets a: existing-apps Integration with existing apps via the add-to-app flow t: gradle "flutter build" and "flutter run" on Android tool Affects the "flutter" command-line tool. See also t: labels. waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants