-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Add flutter assets #38542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flutter assets #38542
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
dnfield
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blasten will probably have much better feedback here, but this breaks some existing tests and doesn't add any new ones to cover this case. We won't be able to merge this PR without addressing those issues.
|
For reference, this is being discussed on #38286 |
|
As discussed here and on the issue, this PR needs work on tests. @excitedhaha are you interested in continuing with this PR? |
|
@zanderso ok, I will try to give the exact steps that reproduce the issue |
|
This issue was fixed via #41333. If you still see this issue, feel free to comment on the PR or the issue. |
Description
Fix the problem that no flutter assets merged to the apk.
Related Issues
38286
Tests
Tested in my project