Skip to content

[flutter_tool] Flip create language defaults to swift and kotlin #38339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanderso merged 1 commit into from
Aug 15, 2019
Merged

[flutter_tool] Flip create language defaults to swift and kotlin #38339

zanderso merged 1 commit into from
Aug 15, 2019

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Aug 12, 2019 •
edited
Loading

Description

This PR changes the default languages for the create command. Previous behavior can be recovered by explicitly passing the --ios-language and --android-language flags.

Related Issues

#21190

Tests

Adjusted tests in commands/create_test.dart.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 12, 2019
@codecov
Copy link

codecov bot commented Aug 12, 2019 •
edited
Loading

Codecov Report

Merging #38339 into master will decrease coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38339      +/-   ##
==========================================
- Coverage   56.12%   55.74%   -0.39%     
==========================================
  Files         194      194              
  Lines       18181    18180       -1     
==========================================
- Hits        10204    10134      -70     
- Misses       7977     8046      +69
Flag Coverage Δ
#flutter_tool 55.74% <ø> (-0.39%) ⬇️
Impacted Files Coverage Δ
...ackages/flutter_tools/lib/src/commands/create.dart 72.45% <ø> (ø) ⬆️
...ckages/flutter_tools/lib/src/ios/code_signing.dart 3.03% <0%> (-89.51%) ⬇️
...ages/flutter_tools/lib/src/commands/build_web.dart 30.76% <0%> (-30.77%) ⬇️
...s/flutter_tools/lib/src/windows/visual_studio.dart 76.08% <0%> (-6.53%) ⬇️
...ackages/flutter_tools/lib/src/reporting/usage.dart 84.02% <0%> (-4.17%) ⬇️
packages/flutter_tools/lib/src/version.dart 90.73% <0%> (-1.96%) ⬇️
...r_tools/lib/src/runner/flutter_command_runner.dart 67.76% <0%> (-1.66%) ⬇️
packages/flutter_tools/lib/src/base/terminal.dart 69.23% <0%> (-1.1%) ⬇️
packages/flutter_tools/lib/src/cache.dart 43.5% <0%> (-0.73%) ⬇️
.../flutter_tools/lib/src/runner/flutter_command.dart 79.13% <0%> (+0.43%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdefbef...e74dedf. Read the comment docs.

jonahwilliams
jonahwilliams approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @devoncarew , I think the IDEs might also expose some flutter create configuration as well? I did see them in vscode too

@devoncarew
Copy link
Contributor

devoncarew commented Aug 13, 2019

Thanks, we do expose the options graphically. We'll need to flip our defaults as well; cc @stevemessick.

This was referenced Aug 13, 2019
Closed
Closed
@zanderso zanderso merged commit e24a27d into flutter:master Aug 15, 2019
@zanderso zanderso deleted the flutter-create-flip branch August 15, 2019 19:13
@Hixie
Copy link
Contributor

Hixie commented Aug 23, 2019

Why did this increase basic_material_app_win__compile?

cc @timsneath

@Hixie Hixie mentioned this pull request Aug 24, 2019
Closed
@AndruByrne
Copy link

AndruByrne commented Sep 13, 2019 •
edited
Loading

So, this change in the defaults did not occasion a change to the AndroidStudio UI; you can check off the kotlin box or not, the same thing happens: Kotlin platform code.

Aside: I was one of the early Kotlin advocates at G, but have not seen opportunities for capitalizing on its features while writing basic API calls; I think the Android team may have different requirements than flutter plugin developers, but all that is besides the point...

I would imagine someone would have had to eat this dogfood and try to set up a Java/ObjC plugin; what was their process so that I can repeat it?

I'll go try to throw things at the CLI now...

@devoncarew
Copy link
Contributor

devoncarew commented Sep 13, 2019

So, this change in the defaults did not occasion a change to the AndroidStudio UI; you can check off the kotlin box or not, the same thing happens: Kotlin platform code.

@AndruByrne, what version of the Flutter IntelliJ plugin are you using? Can you open an issue for this at https://github.com/flutter/flutter-intellij/issues? Thanks!

cc @stevemessick

@amirh amirh mentioned this pull request Oct 7, 2019
Open
@AndruByrne
Copy link

AndruByrne commented Oct 31, 2019

@devoncarew Android Studio 3.5.1; did all the updates, closed the studio, rebooted the computer, made new Flutter Plugin and...

wilco

@AndruByrne AndruByrne mentioned this pull request Oct 31, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Hixie Hixie Awaiting requested review from Hixie

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zanderso @devoncarew @Hixie @AndruByrne @jonahwilliams @googlebot @fluttergithubbot