Don't enable scroll wheel when scrolling is off#37211
Merged
stuartmorgan-g merged 5 commits intoflutter:masterfrom Aug 3, 2019
Merged
Don't enable scroll wheel when scrolling is off#37211stuartmorgan-g merged 5 commits intoflutter:masterfrom
stuartmorgan-g merged 5 commits intoflutter:masterfrom
Conversation
NeverScrollableScrollPhysics should prevent all scrolling, but the new scrollwheel codepath wasn't checking it. Fixes flutter#35304
gspencergoog
approved these changes
Aug 1, 2019
Contributor
gspencergoog
left a comment
There was a problem hiding this comment.
Modulo adding null check.
Co-Authored-By: Greg Spencer <gspencergoog@users.noreply.github.com>
…/flutter into disable-scrollwheel
This was referenced Nov 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NeverScrollableScrollPhysics should prevent all scrolling, but the new scrollwheel codepath wasn't checking it.
Related Issues
Fixes #35304
Tests
I added the following tests: 'Scroll pointer signals are ignored when scrolling is disabled'
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?