add a temporary .analysis_options for flutter_tools #3376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - annotate_overrides | ||
| - sort_unnamed_constructors_first | ||
| - unnecessary_brace_in_string_interp | ||
| - unnecessary_getters_setters |
Contributor
There was a problem hiding this comment.
I notice this is a small subset of the lint rules enumerated in flutter_analysis_options. Curious what the rationale is? I would have expected them all % public_member_api_docs?
Contributor
Author
There was a problem hiding this comment.
I didn't want another copy of that file to maintain :) I just need the few that I hit on a regular basis (and see failures on travis with).
Contributor
|
LGTM so long as Atom doesn't have any new complaints as a result. |
This was referenced Dec 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a temporary .analysis_options for flutter_tools - this will help me not break travis.
flutter_analysis_optionswill remain the system of record. We can delete this file once flutter analyze and analysis server based products are better unified.@Hixie @pq