Skip to content

let ListWheelViewport composite again #33070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xster wants to merge 3 commits into from
Closed

let ListWheelViewport composite again #33070

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f0b561
let ListWheelViewport composite again
xster May 20, 2019
bef44f0
revert driveby
xster May 20, 2019
74f4eba
Merge branch 'master' of github.com:flutter/flutter into listwheel-co…
xster Aug 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/flutter/lib/src/rendering/list_wheel_viewport.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,12 +878,12 @@ class RenderListWheelViewport

// Clipping the part in the center.
context.pushClipRect(
false,
needsCompositing,
offset,
centerRect,
(PaintingContext context, Offset offset) {
context.pushTransform(
false,
needsCompositing,
offset,
_magnifyTransform(),
(PaintingContext context, Offset offset) {
Expand All @@ -895,7 +895,7 @@ class RenderListWheelViewport

// Clipping the part in either the top-half or bottom-half of the wheel.
context.pushClipRect(
false,
needsCompositing,
offset,
untransformedPaintingCoordinates.dy <= magnifierTopLinePosition
? topHalfRect
Expand Down Expand Up @@ -928,9 +928,7 @@ class RenderListWheelViewport
Offset offsetToCenter,
) {
context.pushTransform(
// Text with TransformLayers and no cullRects currently have an issue rendering
// https://github.com/flutter/flutter/issues/14224.
false,
needsCompositing,
offset,
_centerOriginTransform(cylindricalTransform),
// Pre-transform painting function.
Expand Down