Support for replacing the TabController, after disposing the old one #32434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsonmh
approved these changes
May 9, 2019
| /// of this property is [kAlwaysCompleteAnimation]. | ||
| Animation<double> get animation => _animationController?.view ?? kAlwaysCompleteAnimation; | ||
| final AnimationController _animationController; | ||
| /// If the TabController was disposed then return null. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// If the TabController was disposed then return null. | |
| /// If the [TabController] was disposed then return null. |
| expect(controller.length, 3); | ||
| expect(find.text('Tab0'), findsOneWidget); | ||
| expect(find.text('Tab1'), findsOneWidget); | ||
| expect(find.text('Tab2'), findsOneWidget); |
Contributor
There was a problem hiding this comment.
should you also add an:
expect(find.text('Tab3'), findsOneWidget);Now that there should be an additional tab?
Contributor
Author
There was a problem hiding this comment.
I'm changing the length from 2 - 3
9 tasks
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32428