Fix benchmark regression in layer.find<S>(Offset) #32425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a186b7d to
79c7700
Compare
79c7700 to
675892c
Compare
Contributor
|
Should we consider replacing the sync* implementation with something that returns a List (once we have a benchmark covering it?). |
Contributor
Author
|
Yeah, maybe. I'll look at that after this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a benchmark regression introduced in #32350. The performance is improved by just reverting the
Layer.find<S>routines to use their old definitions, instead of defining them in terms of thefindAll<S>lazy iterators.Related Issues
Fixes #32387