Skip to content

Conversation

@GaryQian
Copy link
Contributor

@GaryQian GaryQian commented May 3, 2019

Rolls back what originally seemed like a trivial change, but turned out not to be.

The positioning of the caret on placeholder text is incorrect.

Original PR: #31687

@GaryQian
Copy link
Contributor Author

GaryQian commented May 3, 2019

This change is the non-ios portion of the #31687 PR extracted and reverted.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GaryQian GaryQian merged commit 3bd1737 into flutter:master May 3, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants