Skip to content

Cupertino Turkish Translation #32013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xster merged 1 commit into from
May 3, 2019
Merged

Cupertino Turkish Translation #32013

xster merged 1 commit into from
May 3, 2019

Conversation

@furkantektas
Copy link
Contributor

@furkantektas furkantektas commented May 3, 2019

Description

Turkish translations added for Cupertino.
/cc @xster

Maybe @nyener can help you verify.

Related Issues

#13452

Tests

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

xster
xster reviewed May 3, 2019
View reviewed changes
packages/flutter_localizations/lib/src/l10n/cupertino_tr.arb
"alertDialogLabel": "Uyarı",
"timerPickerHourLabelOne": "saat",
"timerPickerHourLabelOther": "saat",
"timerPickerMinuteLabelOne": "dk.",
Copy link
Member

@xster xster May 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these how iOS abbreviates them?

Copy link
Contributor Author

@furkantektas furkantektas May 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I double-checked these using the stock Clock app.

IMG_B49FF14C2E9B-1

@xster xster added a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels May 3, 2019
@xster
Copy link
Member

xster commented May 3, 2019

Thanks for your contribution and for double checking. Note that the .dart file is generated so it may be overwritten in the future but I've ported back your suggestions back to the source of truth in the translation console.

@xster xster merged commit 299ce6e into flutter:master May 3, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xster xster xster left review comments

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@furkantektas @xster @googlebot