Skip to content

Conversation

@sensuikan1973
Copy link
Contributor

@sensuikan1973 sensuikan1973 commented Apr 30, 2019

Description

When I read catalog example, I found unnecessary artificial delay Now.
It is because #12896 Merged. So, I remove the line.

Related Issues

Tests

no addition.
test task code is https://github.com/flutter/flutter/blob/master/dev/devicelab/lib/tasks/sample_catalog_generator.dart#L30-L37

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@sensuikan1973
Copy link
Contributor Author

@Hixie Would you review this ?

@goderbauer goderbauer added d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. labels Apr 30, 2019
@Hixie
Copy link
Contributor

Hixie commented Apr 30, 2019

Do we have any code anywhere that tests that this code works when generated?

@sensuikan1973
Copy link
Contributor Author

@Hixie
Copy link
Contributor

Hixie commented Apr 30, 2019

Great.

LGTM

@Piinks Piinks merged commit 72a72b3 into flutter:master May 3, 2019
@sensuikan1973 sensuikan1973 deleted the refactor_catalog_example branch May 5, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants