Closed - Integrating Skia Gold for Golden File Testing #31630
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Apr 29, 2019
dnfield
reviewed
Apr 29, 2019
| ); | ||
| }, skip: true); // Should only be on linux (skip: !Platform.isLinux). | ||
| // Disabled for now until font inconsistency is resolved. | ||
| },); |
Contributor
There was a problem hiding this comment.
Does this resolve font inconsistencies the original one mentioned?
Contributor
Author
There was a problem hiding this comment.
I am not certain yet. I wanted to try to test it across platforms and see if it is no longer an issue due the fact that Skia Gold manages all potential variations of a golden file. In this system there is no singular, true golden master, but several.
Piinks
commented
May 2, 2019
Updating gold branch
Piinks
commented
May 10, 2019
Contributor
Author
Piinks
left a comment
There was a problem hiding this comment.
Reverting back from matchesSkiaGoldFile
Updating fork
Updating gold branch
Contributor
Author
|
This PR has gotten a bit hard to read against the diff after a bad merge. Closing in favor of opening a new one. Will reference in the new PR to maintain a link. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed for transitional plan
See #33688
Description
Integrating Flutter golden file testing with Skia Gold
Related Issues
testWidgets#16859Tests
WIP
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?