Allow all tests to run with --update-goldens. #31562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aam
reviewed
Apr 24, 2019
tvolkert
approved these changes
Apr 24, 2019
Contributor
tvolkert
left a comment
There was a problem hiding this comment.
LGTM modulo one remaining comment.
mkustermann
approved these changes
Apr 25, 2019
| class LiveTestWidgetsFlutterBinding extends TestWidgetsFlutterBinding { | ||
| @override | ||
| void initInstances() { | ||
| super.initInstances(); |
Member
There was a problem hiding this comment.
I think the flutter analyze step fails because this method is not necessary anymore. Could you remove it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Resurrecting #31554 because using our 3xH patch will cause other problems).
Previously benchmark_test.dart would terminate flutter test if all tests are run with --update-goldens.
It is important for the Dart team to be able to run all tests this way to avoid maintaining golden files.