Skip to content

check if project exists before regenerating platform specific tooling #31342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 5 commits into from
Apr 22, 2019
Merged

check if project exists before regenerating platform specific tooling #31342

jonahwilliams merged 5 commits into from
Apr 22, 2019

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Apr 20, 2019 •
edited
Loading

Description

Currently we always regenerate platform specific android and ios folders when doing plugin injection, regardless of whether the app has an android or ios project. We should change that logic so that regeneration only applies if the app is a module or if there is a preexisting folder.

Related Issues

Fixes #31341
Fixes #20110

@jonahwilliams jonahwilliams added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 20, 2019
@jonahwilliams jonahwilliams marked this pull request as ready for review April 22, 2019 20:57
@jonahwilliams jonahwilliams requested a review from dnfield April 22, 2019 21:59
dnfield
dnfield approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit a476a08 into flutter:master Apr 22, 2019
@jonahwilliams jonahwilliams deleted the check_project_for_regen branch April 22, 2019 22:18
@jonahwilliams jonahwilliams mentioned this pull request Apr 24, 2019
Closed
@jmagman jmagman mentioned this pull request Oct 17, 2020
Merged
10 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deleted android/ directory shouldn't be recreated when building an iOS-only app Flutter tool crashes on Android only app with plugins

3 participants

@jonahwilliams @dnfield @googlebot