-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Add BottomSheetTheme to enable theming color, elevation, shape of BottomSheet #31318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
825c6e5 to
da9ee6b
Compare
johnsonmh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice simple addition. Mostly just some comments about testing.
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good; I think one final round or simplification is possible.
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This change introduces a BottomSheetTheme that allows you to theme color, elevation, and shape of BottomSheet. This can be done at the theme level and at call time of
showBottomSheetandshowModalBottomSheet. See the following image for an example (with some questionable design choices):Related Issues
Closes #26854
Closes #30444
Tests
I added the following tests:
BottomSheetitselfshowBottomSheetandshowModalBottomSheetpass through color/elevation/shape to theBottomSheetChecklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?