Skip to content

Conversation

@LongCatIsLooong
Copy link
Contributor

Description

  • Added docs to AppBar to cover AppBar's inherited MediaQuery when not used in a Scaffold in general
  • Also did a s/Hero]s/Hero]es/

Related Issue

(sort of) addresses #27848

Tests

N/A

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@LongCatIsLooong LongCatIsLooong added the d: api docs Issues with https://api.flutter.dev/ label Apr 19, 2019
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Piinks Piinks added the framework flutter/packages/flutter repository. See also f: labels. label Apr 22, 2019
@HansMuller HansMuller added the f: material design flutter/packages/flutter/material repository. label Apr 25, 2019
@LongCatIsLooong LongCatIsLooong force-pushed the hero-animation-with-bottom-padding branch from b7b8af4 to c0e5bb2 Compare April 26, 2019 01:22
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongCatIsLooong LongCatIsLooong merged commit 15f187f into flutter:master May 2, 2019
@LongCatIsLooong LongCatIsLooong deleted the hero-animation-with-bottom-padding branch May 2, 2019 03:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants