Add flutter run support for linux and windows #31229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Haven't tested the windows logic end to end yet, getting my home windows machine set up for it currently. |
Contributor
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Working through issues with Windows. So far:
- project.dart accidentally used name_output.sh instead of name_output.bat, which we should fold a fix for into this patch
- "Cannot find executable for Get-CimInstance Win32_Process". Is processManager.runSync running things in PowerShell?
Contributor
Author
|
Updated the process script to try and run through power shell, fixed the typo in the windows project. Time to write tests. |
stuartmorgan-g
approved these changes
Apr 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds buildable application packages for Windows and Linux, and allows running them.
Related Issues
#30707
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?