Fuchsia step 1: add SDK version file and artifact download #31073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 15, 2019 18:15
zanderso
approved these changes
Apr 16, 2019
Member
There was a problem hiding this comment.
How hard would it be to split off the web, linux, etc. artifacts into an UnstableDevelopmentArtifacts? Then you could do something like.
for (DevelopmentArtifact artifact in DevelopmentArtifacts.values) {
if (argResults[artifact.toString()]) {
requiredArtifacts.add(artifact);
}
}
if (!FlutterVersion.instance.isStable) {
for (UnstableDevelopmentArtifact artifact in UnstableDevelopmentArtifacts.values) {
if (argResults[artifact.toString()]) {
requiredArtifacts.add(artifact);
}
}
}
Or maybe put the unstable development artifacts beyond some dummy marker in DevelopmentArtifacts and then iterate over the indices of DevelopmentArtifacts.values before/after that marker.
Contributor
Author
There was a problem hiding this comment.
Updated DevelopmentArtifacts to be a class with a name/unstable marker, ptal?
4a2b387 to
8c1903c
Compare
zanderso
approved these changes
Apr 16, 2019
Member
zanderso
left a comment
There was a problem hiding this comment.
still lgtm w/ a couple more nits.
| universal, | ||
| static const DevelopmentArtifact universal = DevelopmentArtifact._('universal'); | ||
|
|
||
| /// THe vaulues of DevelopmentArtifacts. |
|
|
||
| /// A tag for a set of development artifacts that need to be cached. | ||
| enum DevelopmentArtifact { | ||
| class DevelopmentArtifact { |
added 2 commits
April 16, 2019 10:28
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a version file to the bin/internal with the current (arbitrary) hash of the fuchsia sdk to download. Adds the ability to run
flutter precache --fuchsiaon non-stable branches.Related Issues
Fixes #31102
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?