fix issue 30526: rounding error #30979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
Apr 24, 2019
Contributor
There was a problem hiding this comment.
We'll want to watch this for benchmarks.
Contributor
|
@chunhtai we want to land this right? Are you just waiting for the tree to be green? |
Contributor
Author
Contributor
|
#31890 has been merged. Ready when the tree is green? |
Contributor
Author
yes, I will rebase this pr, but it seems like the build is currently broken |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr only fixes the rounding error outline in the issue
Related Issues
#30526
Tests
I added the following tests:
https://github.com/chunhtai/flutter/blob/fb7ab807481d90a19f359831f2d14584de1945b3/packages/flutter/test/rendering/sliver_fixed_extent_layout_test.dart#L12
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?