Skip to content

Conversation

@nikitadol
Copy link
Contributor

@nikitadol nikitadol commented Mar 31, 2019

Description

If you pass an asynchronous function to the compute method, it will not execute it.

Related Issues

#16265
#25890

Tests

I added the following tests:

  • computeFuture()

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@goderbauer goderbauer added the framework flutter/packages/flutter repository. See also f: labels. label Mar 31, 2019
@goderbauer goderbauer requested a review from Hixie March 31, 2019 22:10
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit

@goderbauer goderbauer merged commit 88d50f7 into flutter:master Apr 4, 2019
@nikitadol nikitadol deleted the feature/compute branch April 4, 2019 07:27
@nikitadol nikitadol restored the feature/compute branch April 4, 2019 07:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants