Skip to content

Adds FocusHighlight widget to show highlights around focused widgets. #30077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gspencergoog wants to merge 2 commits into from
Closed

Adds FocusHighlight widget to show highlights around focused widgets. #30077

gspencergoog wants to merge 2 commits into from

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Mar 28, 2019 •
edited
Loading

Description

This implements a FocusHighlight widget to do highlighting of focused widgets, in addition to some examples and manual tests for focus.

It also currently includes the contents of #30076, which will be rebased out after that is committed.
Here is a diff of the two so it's obvious what is included here.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@gspencergoog gspencergoog changed the title Focus addons Adds FocusHighlight widget to show highlights around focused widgets. Mar 28, 2019
@gspencergoog gspencergoog mentioned this pull request Mar 28, 2019
Merged
9 tasks
@gspencergoog gspencergoog force-pushed the focus_addons branch 7 times, most recently from e54eae6 to e933b67 Compare March 29, 2019 21:45
@goderbauer goderbauer added framework flutter/packages/flutter repository. See also f: labels. a: desktop Running on desktop labels Mar 30, 2019
@gspencergoog gspencergoog force-pushed the focus_addons branch 9 times, most recently from 3fd9bf5 to 6bdb4d4 Compare April 3, 2019 04:45
Hixie
Hixie reviewed Apr 3, 2019
View reviewed changes
Hixie
Hixie reviewed Apr 3, 2019
View reviewed changes
Hixie
Hixie reviewed Apr 3, 2019
View reviewed changes
Hixie
Hixie reviewed Apr 3, 2019
View reviewed changes
Hixie
Hixie reviewed Apr 3, 2019
View reviewed changes
Hixie
Hixie reviewed Apr 3, 2019
View reviewed changes
Hixie
Hixie reviewed Apr 3, 2019
View reviewed changes
Hixie
Hixie reviewed Apr 3, 2019
View reviewed changes
Hixie
Hixie reviewed Apr 3, 2019
View reviewed changes
@gspencergoog gspencergoog force-pushed the focus_addons branch 14 times, most recently from 8fd4823 to 9127e86 Compare May 1, 2019 21:09
@gspencergoog gspencergoog force-pushed the focus_addons branch 8 times, most recently from 6622b7b to 4349eca Compare May 10, 2019 00:38
Hixie
Hixie reviewed May 11, 2019
View reviewed changes
packages/flutter/lib/src/material/focus_highlight.dart Outdated
Copy link
Contributor

@Hixie Hixie May 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the pattern in the style guide

@gspencergoog
Copy link
Contributor Author

gspencergoog commented May 15, 2019

Closing this, since I decided that the FocusHighlight widget is a) easy for someone to create if they need it, and 2) isn't needed at all by Material Design widgets, since they all do focus highlights differently than it would.

I'll move some of the minor cleanups that were here into another PR.

@gspencergoog gspencergoog deleted the focus_addons branch May 15, 2019 16:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Hixie Hixie Hixie left review comments

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

a: desktop Running on desktop framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gspencergoog @Hixie @goderbauer @googlebot