Skip to content

TextField Validator Height Docs #29811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinmc merged 1 commit into from
Mar 27, 2019
Merged

TextField Validator Height Docs #29811

justinmc merged 1 commit into from
Mar 27, 2019

Conversation

@justinmc
Copy link
Contributor

@justinmc justinmc commented Mar 22, 2019

Closes #15400

When using a TextFormField with a validator function, users were sometimes surprised to see that the TextFormField would grow when an error appeared.

Input without error
flutter_01

This PR updates the documentation to include useful fixes to this problem.

@justinmc justinmc self-assigned this Mar 22, 2019
@justinmc justinmc requested a review from HansMuller March 22, 2019 20:28
@goderbauer goderbauer added the framework flutter/packages/flutter repository. See also f: labels. label Mar 25, 2019
@HansMuller HansMuller added the f: material design flutter/packages/flutter/material repository. label Mar 26, 2019
HansMuller
HansMuller approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinmc justinmc merged commit ed95096 into flutter:master Mar 27, 2019
@justinmc justinmc deleted the text-validator-height branch March 27, 2019 16:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@justinmc justinmc

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TextField height changes if the errorText shows

4 participants

@justinmc @HansMuller @goderbauer @googlebot