Skip to content

Revert "Roll engine f4951df193a7..471a2c89a689 (11 commits)" #28975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Mar 7, 2019
Merged

Revert "Roll engine f4951df193a7..471a2c89a689 (11 commits)" #28975

jonahwilliams merged 1 commit into from
Mar 7, 2019

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 7, 2019 •
edited
Loading

Unbreak flutter build

Error on devicelab caused by missing enum in pointer.dart

ecuting: /Volumes/DevicelabAndroid/sdk/platform-tools/adb -s ZY22465W9K shell input tap 100 100
2019-03-06T16:19:46.016310: run:stdout: [+1392 ms] E/flutter (15708): [ERROR:flutter/shell/common/shell.cc(178)] Dart Error: Unhandled exception:
2019-03-06T16:19:46.016516: run:stdout: [        ] E/flutter (15708): RangeError (index): Invalid value: Not in range 0..4, inclusive: 5
run:stdout: [        ] E/flutter (15708): #0      List.[] (dart:core/runtime/lib/array.dart:161:52)
2019-03-06T16:19:46.016660: run:stdout: [        ] E/flutter (15708): #1      _unpackPointerDataPacket (dart:ui/hooks.dart:275:37)
2019-03-06T16:19:46.016943: run:stdout: [        ] E/flutter (15708): #2      _dispatchPointerDataPacket (dart:ui/hooks.dart:144:94)
2019-03-06T16:19:46.017514: run:stdout: [        ] E/flutter (15708): [ERROR:flutter/shell/common/shell.cc(178)] Dart Error: Unhandled exception:
2019-03-06T16:19:46.017718: run:stdout: [        ] E/flutter (15708): RangeError (index): Invalid value: Not in range 0..4, inclusive: 5
2019-03-06T16:19:46.017968: run:stdout: [        ] E/flutter (15708): #0      List.[] (dart:core/runtime/lib/array.dart:161:52)
2019-03-06T16:19:46.018177: run:stdout: [        ] E/flutter (15708): #1      _unpackPointerDataPacket (dart:ui/hooks.dart:275:37)
2019-03-06T16:19:46.018393: run:stdout: [        ] E/flutter (15708): #2      _dispatchPointerDataPacket (dart:ui/hooks.dart:144:94)
2019-03-06T16:19:46.034025: "/Volumes/DevicelabAndroid/sdk/platform-tools/adb" exit code: 0

Fix is pending here: flutter/engine#8065

Reverts #28966

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Mar 7, 2019

TBR @goderbauer

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Mar 7, 2019

Landing on red to fix build

@jonahwilliams jonahwilliams merged commit cd1b89c into master Mar 7, 2019
@jonahwilliams jonahwilliams deleted the revert-28966-roll_branch branch March 7, 2019 01:42
@goderbauer
Copy link
Member

goderbauer commented Mar 7, 2019

LGTM

Can you link to some of the breaking things from this revert so future me knows why this got reverted?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @goderbauer @googlebot