Skip to content

Conversation

@DanTup
Copy link
Contributor

@DanTup DanTup commented Feb 28, 2019

Description

This fixes an annotation on Flutter's test group wrapper function which was incorrectly marked with @isTest instead of @isTestGroup in my previous PR (#27532).

The function wrapped by this function can be seen here (and is annotated using @isTestGroup and not @isTest):

https://github.com/dart-lang/test/blob/a2eff0641fe0245921e49d8b0506e34536631dac/pkgs/test_api/lib/test_api.dart#L170

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
    • There are no tests covering this annotation, it's used only by the analysis server when constructing the Outline (so this functionality is tested in the analyzer), however I've added additional integration tests in Dart Code to test the outline comes through correctly (Dart-Code/Dart-Code@7c0d350)
  • All existing and new tests are passing.
  • N/A I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

(cc @scheglov @jonahwilliams since you reviewed the original PR :-))

@goderbauer goderbauer added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Mar 1, 2019
@DanTup DanTup merged commit 740fb2a into flutter:master Mar 2, 2019
@DanTup DanTup deleted the test-group branch March 2, 2019 13:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"No tests match regular expression" when running tests with "Dart: Run Test At Cursor" command

4 participants