Add long-press-move support for text fields 2 #28242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5bd41fc to
c567df0
Compare
goderbauer
reviewed
Feb 21, 2019
Member
goderbauer
left a comment
There was a problem hiding this comment.
First pass-through with just some nits.
This should probably get the label "API break". Did you already send out communications regarding this break?
goderbauer
approved these changes
Feb 22, 2019
Member
goderbauer
left a comment
There was a problem hiding this comment.
LGTM if the breaking change has been communicated.
| this.onDoubleTap, | ||
| this.onLongPress, | ||
| this.onLongPressUp, | ||
| this.onLongPressStart, |
Member
There was a problem hiding this comment.
You didn't like this suggestion? :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a retake of #26001
Allows the long press gesture to move after being accepted.
Use on iOS to move text field cursor. Use on Android to expand selections of words on text fields.
Left #26394 for Android
Related Issues
Fixes #20693.
Checklist
Before you create this PR confirm that it meets all requirements listed below
by checking the relevant checkboxes (
[x]). This will ensure a smooth and quickreview process.
submitting PRs.
Test Coverage).
///).flutter analyze --flutter-repo) does not report anyproblems on my PR.
Features we expect every widget to implement.
Breaking Change
Does your PR require Flutter developers to manually update their apps
to accommodate your change?
LongPressGestureRecognizers will start to emit onLongPressUp even after the gesture moved after the long press is accepted by default unless a different postAcceptSlopTolerance value is given in the constructor.