Skip to content

[Material] Update BottomNavigationBar motion to current Material guidelines #27008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnsonmh wants to merge 12 commits into from
Closed

[Material] Update BottomNavigationBar motion to current Material guidelines #27008

johnsonmh wants to merge 12 commits into from

Conversation

@johnsonmh
Copy link
Contributor

@johnsonmh johnsonmh commented Jan 24, 2019 •
edited
Loading

Update BottomNavigationBars motion to be up to date with Material Design standards.

Current Material Design guidelines for BottomNavigationBar.

Changes:

  • "Fixed" Bottom navigation bar label text no longer grows when selected.
  • "Fixed" Bottom navigation bar icon + text no longer rise when selected.
  • "Shifting" Bottom navigation bar icon + text no longer Move in the X direction.
BottomNavigationBarType Current Proposed
Fixed b1 a1
Shifting b2 giphy

Note:

  • This PR involves visual changes.
  • This PR does not affect the API in any way.

Updated goldens for bottom_navigation_bar_test flutter/goldens@b15e2ee

Closes #23178

@johnsonmh johnsonmh requested a review from HansMuller January 24, 2019 03:45
@zoechi zoechi added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jan 24, 2019
@johnsonmh johnsonmh force-pushed the feature-materialBottomNav branch from ea6c7ad to 33bde2c Compare January 30, 2019 18:25
@marcoms marcoms mentioned this pull request Feb 1, 2019
Closed
@johnsonmh johnsonmh force-pushed the feature-materialBottomNav branch from d009cbd to a2d43fe Compare February 5, 2019 01:26
@Hixie
Copy link
Contributor

Hixie commented Feb 5, 2019

LGTM

@Hixie
Copy link
Contributor

Hixie commented Feb 5, 2019

I updated the PR to point to the latest goldens.

@johnsonmh
Copy link
Contributor Author

johnsonmh commented Feb 8, 2019

Closing in favor of #27698, which, rather than make a visually breaking change that takes away the old functionality, expands on the BottomNavigationBar API and allows for several requested features in addition to the behaviors described here.

@johnsonmh johnsonmh closed this Feb 8, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BottomNavigationBar animation exceeds Material spec

4 participants

@johnsonmh @Hixie @zoechi @googlebot