Skip to content

Fixes to support add2app on iOS #22277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnfield merged 4 commits into from
Sep 26, 2018
Merged

Fixes to support add2app on iOS #22277

dnfield merged 4 commits into from
Sep 26, 2018

Conversation

@mravn
Copy link
Contributor

@mravn mravn commented Sep 25, 2018 •
edited
Loading

  • Relative path mixup which doesn't matter to ephemeral or editable host app, but does to host app in add2app scenarios.
  • Pod for generated plugin registrant used too old deployment version for new Xcode (7.0 -> 8.0)
  • Fixed up dev/integration_tests/ios_host_app to work in Xcode 10.0

/cc @dnfield

@mravn mravn mentioned this pull request Sep 25, 2018
Merged
@mravn mravn changed the title Fix xcode_backend.sh script to support add2app Fixes to support add2app on iOS Sep 25, 2018
@dnfield
Copy link
Contributor

dnfield commented Sep 25, 2018

Does this break Xcode 9.4?

Sorry about the misunderstanding on the other PR, thought it was good to go.

@mravn
Copy link
Contributor Author

mravn commented Sep 25, 2018

@dnfield I don't think it does, but I'm not going to downgrade to 9.4 to test it tonight. Feel free, if you have 9.4 on a MacBook near you:

Check out this PR in a branch, then

cd some/path/
flutter create -t module --org io.flutter.add2app hello
cp -R /path/to/flutter/dev/integration_test/ios_host_app Host/
cd Host/
pod install

Now you should be able to open Host/Host.xcworkspace in Xcode and build+run it.

No apologies needed about the other PR! My bad with all the checkmarks. Anyway, it went fine on the build bots, it seems :-)

@dnfield
Copy link
Contributor

dnfield commented Sep 26, 2018

LGTM

@dnfield dnfield merged commit 52697ef into flutter:master Sep 26, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dnfield dnfield dnfield left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mravn @dnfield @googlebot