Skip first time full dill transfer #21133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Sep 11, 2018
| if (compiledBinary != null && compiledBinary.isNotEmpty) { | ||
| final Uri entryUri = fs.path.toUri(projectRootPath != null ? | ||
| fs.path.relative(pathToReload, from: projectRootPath) : | ||
| pathToReload); |
Contributor
There was a problem hiding this comment.
nit: indentation here is confusing
Member
Author
There was a problem hiding this comment.
Yeah, IJ auto-indenter took over as soon as added curly braces.
Contributor
|
I assume the dill is now bundled in the debug-mode APK? code LGTM. |
Member
Author
Right. |
a-siva
approved these changes
Sep 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve hotReloadInitialDevFSSyncMilliseconds and hotReloadInitialDevFSSyncAfterRelaunchMilliseconds benchmarks.