export drawer's open/close callback#20856
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
| final bool primary; | ||
| /// Optional callback that is called when a [Drawer] is opened or closed. | ||
| final DrawerCallback drawerCallback; | ||
| final DrawerCallback endDrawerCallback; |
There was a problem hiding this comment.
This line also needs documentation, and there should be an empty line between every field declaration
|
Any development on this @msyaojz |
|
This is probably not the approach we would want to take for this... I would imagine we would either make |
|
Another possible idea is exposing the (The problem with callbacks is that they wouldn't be usable in other contexts, e.g. you couldn't await one, or pass one to an |
|
Because this implementation isn't really the best way of implementing this feature, we're going to close this pull request for now. |
|
Since the CLA wasn't signed on this PR, I'm going to close it. We can't accept patches where the CLA hasn't been signed. @msyaojz if you have the opportunity to sign the CLA, please don't hesitate to do so and open a new PR! Thanks! |
|
This should be resolved by #67249 |
No description provided.