Skip to content

Re-land #18369#19082

Merged
jonahwilliams merged 45 commits into
flutter:masterfrom
jonahwilliams:tap_target_flag
Jul 9, 2018
Merged

Re-land #18369#19082
jonahwilliams merged 45 commits into
flutter:masterfrom
jonahwilliams:tap_target_flag

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

The cause of the test failure was in my redirect hit test logic. If the hit test would have hit the child anyway, then moving the offset to the center could cause the test to fail if the child is off center. This manifested in the gallery test not being able to tap on a category since the finder used the text value, which was below the center of the button.

I've corrected this logic and added new test cases to confirm that it works correctly, and verified with the device lab test locally

Jonah Williams and others added 30 commits May 25, 2018 16:31
@jonahwilliams jonahwilliams requested a review from goderbauer July 9, 2018 16:01

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit 77a528c into flutter:master Jul 9, 2018
@jonahwilliams jonahwilliams deleted the tap_target_flag branch July 9, 2018 19:05
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants