Skip to content

Revert "Add flag to ThemeData to expand tap targets of certain material widgets"#19053

Merged
jonahwilliams merged 1 commit into
masterfrom
revert-18369-tap_target_flag
Jul 3, 2018
Merged

Revert "Add flag to ThemeData to expand tap targets of certain material widgets"#19053
jonahwilliams merged 1 commit into
masterfrom
revert-18369-tap_target_flag

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

Reverts #18369

@xster

xster commented Jul 3, 2018

Copy link
Copy Markdown
Member

LGTM

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :(

@jonahwilliams

Copy link
Copy Markdown
Contributor Author

I've added cases locally to confirm the hitTestable issue and I cannot reproduce it. I doubt this will fix the device lab but I'm submitting it anyway

@jonahwilliams jonahwilliams merged commit cabe09a into master Jul 3, 2018
@jonahwilliams jonahwilliams deleted the revert-18369-tap_target_flag branch July 3, 2018 22:26
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants