Skip to content

Add new matcher and utility methods for testing semanics #19046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonahwilliams merged 10 commits into from
Jul 9, 2018
Merged

Add new matcher and utility methods for testing semanics #19046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1d69291
initial work on android integration testing and new finders for seman…
jonahwilliams Jun 30, 2018
93e9952
update semantics data matcher to only require boolean fields, update …
jonahwilliams Jun 30, 2018
60da7f9
add missing licenses and more semantics test cases, clean up matcher
jonahwilliams Jun 30, 2018
c8825f9
Merge branch 'master' of https://github.com/flutter/flutter into andr…
jonahwilliams Jul 2, 2018
a880491
fork flutter_test changes into separate PR
jonahwilliams Jul 3, 2018
2327066
address review comment
jonahwilliams Jul 3, 2018
0ba16c5
fix spacing on back button test
jonahwilliams Jul 3, 2018
e691d9f
rename actions and fix doc comment issue
Jul 9, 2018
887b36a
address review commits
Jul 9, 2018
6288726
Address comments
Jul 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions packages/flutter/test/material/back_button_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// found in the LICENSE file.

import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
Expand Down Expand Up @@ -59,4 +60,35 @@ void main() {
final Icon androidIcon = tester.widget(find.descendant(of: find.byKey(androidKey), matching: find.byType(Icon)));
expect(iOSIcon == androidIcon, false);
});

testWidgets('BackButton semantics', (WidgetTester tester) async {
final SemanticsHandle handle = tester.ensureSemantics();
await tester.pumpWidget(
new MaterialApp(
home: const Material(child: const Text('Home')),
routes: <String, WidgetBuilder>{
'/next': (BuildContext context) {
return const Material(
child: const Center(
child: const BackButton(),
),
);
},
},
),
);

tester.state<NavigatorState>(find.byType(Navigator)).pushNamed('/next');

await tester.pumpAndSettle();

expect(tester.getSemanticsData(find.byType(BackButton)), matchesSemanticsData(
label: 'Back',
isButton: true,
hasEnabledState: true,
isEnabled: true,
hasTapAction: true,
));
handle.dispose();
});
}
111 changes: 34 additions & 77 deletions packages/flutter/test/material/checkbox_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ void main() {
});

testWidgets('CheckBox semantics', (WidgetTester tester) async {
final SemanticsTester semantics = new SemanticsTester(tester);
final SemanticsHandle handle = tester.ensureSemantics();

await tester.pumpWidget(new Material(
child: new Checkbox(
Expand All @@ -41,21 +41,12 @@ void main() {
),
));

expect(semantics, hasSemantics(new TestSemantics.root(
children: <TestSemantics>[
new TestSemantics.rootChild(
id: 1,
flags: <SemanticsFlag>[
SemanticsFlag.hasCheckedState,
SemanticsFlag.hasEnabledState,
SemanticsFlag.isEnabled,
],
actions: <SemanticsAction>[
SemanticsAction.tap,
],
),
],
), ignoreRect: true, ignoreTransform: true));
expect(tester.getSemanticsData(find.byType(Checkbox)), matchesSemanticsData(
hasCheckedState: true,
hasEnabledState: true,
isEnabled: true,
hasTapAction: true,
));

await tester.pumpWidget(new Material(
child: new Checkbox(
Expand All @@ -64,22 +55,13 @@ void main() {
),
));

expect(semantics, hasSemantics(new TestSemantics.root(
children: <TestSemantics>[
new TestSemantics.rootChild(
id: 1,
flags: <SemanticsFlag>[
SemanticsFlag.hasCheckedState,
SemanticsFlag.isChecked,
SemanticsFlag.hasEnabledState,
SemanticsFlag.isEnabled,
],
actions: <SemanticsAction>[
SemanticsAction.tap,
],
),
],
), ignoreRect: true, ignoreTransform: true));
expect(tester.getSemanticsData(find.byType(Checkbox)), matchesSemanticsData(
hasCheckedState: true,
hasEnabledState: true,
isChecked: true,
isEnabled: true,
hasTapAction: true,
));

await tester.pumpWidget(const Material(
child: const Checkbox(
Expand All @@ -88,17 +70,10 @@ void main() {
),
));

expect(semantics, hasSemantics(new TestSemantics.root(
children: <TestSemantics>[
new TestSemantics.rootChild(
id: 1,
flags: <SemanticsFlag>[
SemanticsFlag.hasCheckedState,
SemanticsFlag.hasEnabledState,
],
),
],
), ignoreRect: true, ignoreTransform: true));
expect(tester.getSemanticsData(find.byType(Checkbox)), matchesSemanticsData(
hasCheckedState: true,
hasEnabledState: true,
));

await tester.pumpWidget(const Material(
child: const Checkbox(
Expand All @@ -107,24 +82,16 @@ void main() {
),
));

expect(semantics, hasSemantics(new TestSemantics.root(
children: <TestSemantics>[
new TestSemantics.rootChild(
id: 1,
flags: <SemanticsFlag>[
SemanticsFlag.hasCheckedState,
SemanticsFlag.isChecked,
SemanticsFlag.hasEnabledState,
],
),
],
), ignoreRect: true, ignoreTransform: true));

semantics.dispose();
expect(tester.getSemanticsData(find.byType(Checkbox)), matchesSemanticsData(
hasCheckedState: true,
hasEnabledState: true,
isChecked: true,
));
handle.dispose();
});

testWidgets('Can wrap CheckBox with Semantics', (WidgetTester tester) async {
final SemanticsTester semantics = new SemanticsTester(tester);
final SemanticsHandle handle = tester.ensureSemantics();

await tester.pumpWidget(new Material(
child: new Semantics(
Expand All @@ -137,25 +104,15 @@ void main() {
),
));

expect(semantics, hasSemantics(new TestSemantics.root(
children: <TestSemantics>[
new TestSemantics.rootChild(
id: 1,
label: 'foo',
textDirection: TextDirection.ltr,
flags: <SemanticsFlag>[
SemanticsFlag.hasCheckedState,
SemanticsFlag.hasEnabledState,
SemanticsFlag.isEnabled,
],
actions: <SemanticsAction>[
SemanticsAction.tap,
],
),
],
), ignoreRect: true, ignoreTransform: true));

semantics.dispose();
expect(tester.getSemanticsData(find.byType(Checkbox)), matchesSemanticsData(
label: 'foo',
textDirection: TextDirection.ltr,
hasCheckedState: true,
hasEnabledState: true,
isEnabled: true,
hasTapAction: true,
));
handle.dispose();
});

testWidgets('CheckBox tristate: true', (WidgetTester tester) async {
Expand Down
Loading