Update CHANGELOG.md for Flutter 3.44.3#188180
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request updates the CHANGELOG.md file to document the changes introduced in Flutter version 3.44.3. The review feedback suggests grammatical improvements to the new changelog entries to ensure consistency with existing entries, specifically recommending the use of the imperative mood ('Ensure' and 'Fix') and standard terminology ('destroyed').
|
|
||
| ### [3.44.3](https://github.com/flutter/flutter/releases/tag/3.44.3) | ||
| - [flutter/186738](https://github.com/flutter/flutter/issues/186738) Demote flavor/platform asset skipping messages from warning to trace level to reduce build log noise. | ||
| - [flutter/186899](https://github.com/flutter/flutter/issues/186899) Ensures a GLES fence sync object held by a texture will be deleted if the texture is destructed before the fence was used. |
There was a problem hiding this comment.
To maintain grammatical consistency with the other entries (which use the imperative mood, e.g., 'Demote'), consider using 'Ensure' instead of 'Ensures'. Additionally, 'destroyed' is more standard than 'destructed' in this context.
| - [flutter/186899](https://github.com/flutter/flutter/issues/186899) Ensures a GLES fence sync object held by a texture will be deleted if the texture is destructed before the fence was used. | |
| - [flutter/186899](https://github.com/flutter/flutter/issues/186899) Ensure a GLES fence sync object held by a texture will be deleted if the texture is destroyed before the fence was used. |
| - [flutter/186738](https://github.com/flutter/flutter/issues/186738) Demote flavor/platform asset skipping messages from warning to trace level to reduce build log noise. | ||
| - [flutter/186899](https://github.com/flutter/flutter/issues/186899) Ensures a GLES fence sync object held by a texture will be deleted if the texture is destructed before the fence was used. | ||
| - [flutter/186953](https://github.com/flutter/flutter/issues/186953) When building concurrently with SwiftPM [on macOS/iOS], fix crashes caused by concurrent directory/file/symlink creation. | ||
| - [flutter/183179](https://github.com/flutter/flutter/issues/183179) Fixes an issue that can cause crashes when rendering animated PNG images. |
There was a problem hiding this comment.
To maintain grammatical consistency with the other entries (which use the imperative mood, e.g., 'Demote'), consider using 'Fix' instead of 'Fixes'.
| - [flutter/183179](https://github.com/flutter/flutter/issues/183179) Fixes an issue that can cause crashes when rendering animated PNG images. | |
| - [flutter/183179](https://github.com/flutter/flutter/issues/183179) Fix an issue that can cause crashes when rendering animated PNG images. |
Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>
Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>
0760c4f
into
flutter:flutter-3.44-candidate.0
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.