[CP-beta]Update the list of binaries in the code signing verification test to include new Dart snapshots#188050
Conversation
…include new Dart snapshots (flutter#186754) A recent Dart roll (flutter#186690) changed the format of Dart AOT snapshots so that they are now recognized as binaries by run_verify_binaries_codesigned_tests. The list of expected binaries needs to be updated accordingly.
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request updates run_verify_binaries_codesigned_tests.dart to include several new Dart SDK and engine snapshot binaries in the list of binaries with entitlements. It also updates the isBinary helper function to identify files with the application/x-sharedlib MIME type as binaries. Additionally, a minor formatting change was made in FlutterTextInputPlugin.mm. There are no review comments, and I have no feedback to provide.
|
autosubmit label was removed for flutter/flutter/188050, because - The status or check suite Linux framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
|
auto label is removed for flutter/flutter/188050, Failed to merge flutter/flutter/188050 with Pull request flutter/flutter/188050 could not be merged: Required status check "ci.yaml validation" is expected.. |
1a4b2e6
into
flutter:flutter-3.45-candidate.0
to unblock the beta candidate tree.
This CP combines #186754 and #187378. Also added an empty line to a
.mmfile to trigger engine rebuild.This change won't be merged back to master so the empty line should be fine.
This commit, if merged, won't have an entry in the changelog since it is not user-facing / does not affect app / plugin devs.
Re: the list of binaries, the most recent 2 commits on master that edited
run_verify_binaries_codesigned_tests.darthave both been cherry-picked into the beta branch. I have verified thatgit diff upstream/master -- dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dartis clean.SHARD=verify_binaries_pre_codesigned bin/cache/dart-sdk/bin/dart dev/bots/test.dartfails but that's likely because the engine revision was still on 0a9f488c13.The current dart revision is aad8be4ce3077a809f0b4f3325c6d8a6908aad54
The dart revision associated with #186754 was 66873d2da857,
The dart revision associated with #187378 was 3cdc25e8ffe98c61b36af485573639dc833b75cb